OP-Engineering / op-sqlite

Fastest SQLite library for react-native by @ospfranco
MIT License
593 stars 41 forks source link

[Request]: Bring back sync execute #173

Open pranshuchittora opened 4 weeks ago

pranshuchittora commented 4 weeks ago

What do you need?

Hey, I am using op-sqlite and in the newest version the execute api was changed from sync to async. My use-case requires sync query execution in some cases which can't be changed to async.

https://github.com/OP-Engineering/op-sqlite/commit/1dbc8289e1a04841b1ae08b7fbbf3c849a3454a2#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R127

Is there any possibility to bring back the sync execute? or any workaround for the same?

Thanks

Volland commented 3 weeks ago

we had a similar request some of our api is sync only

ospfranco commented 3 weeks ago

@rflopezm

Here was the change:

https://github.com/OP-Engineering/op-sqlite/pull/142/files#diff-cd0866c167878907e99d1e94024bc05e6f673d0e5228bf11448932f2aaa4d0c2L320

Now there are a couple of differences, before you go re-implementing this interface: