search

OP-Engineering / op-sqlite

Fastest SQLite library for react-native by @ospfranco
MIT License
598 stars 41 forks source link

[Bug]: Pod Install fails with Custom Flags #183

Closed K-Leon closed 1 week ago

K-Leon commented 2 weeks ago

What happened?

Using this SQLITE Flag works on Android perfectly fine:

  "op-sqlite": {
      "sqliteFlags": "-DSQLITE_TEMP_STORE=2"
  },

Pod Install on IOS throws an error.

@op-engineering/op-sqlite/op-sqlite.podspec:163
 #  -------------------------------------------
 #      log_message.call("[OP-SQLITE] Custom SQLite flags: #{sqlite_flags}")
 >      xcconfig[:OTHER_CFLAGS] += " #{sqlite_flags}"
 #    end
 #  -------------------------------------------

I couldn't figure out what is wrong. Thank you very much for your hard work on this plugin!

op-sqlite version

9.3.0

React Native version

0.76.1

Reproducible Example

-

ospfranco commented 2 weeks ago

Yeah, I realized this might be failing the other day. You will have to wait for a bit. I will take a look when I can but it might take a while

K-Leon commented 2 weeks ago

No worries - I'm glad I didn't mess it up :) Thank you very much!

ArindamRayMukherjee commented 1 week ago

+1

Added a reproducible example here - https://github.com/danceaway-app/opsqlite-trials/pull/1

ospfranco commented 1 week ago

This should be fixed in the released version: 10.0.0-tokenizers-beta8. Give it a try there and let me know if it works. At least on the example app pod install now works without issues.

ospfranco commented 1 week ago

Released

https://github.com/OP-Engineering/op-sqlite/releases/tag/10.1.0