search

OP-Engineering / op-sqlite

Fastest SQLite library for react-native by @ospfranco
MIT License
465 stars 28 forks source link

Windows support #43

Open listepo opened 6 months ago

listepo commented 6 months ago

It would be nice to have support for MacOS and Windows

ospfranco commented 6 months ago

macos is already supported. I don't know how windows modules work, so PRs are welcome

listepo commented 6 months ago

@ospfranco https://github.com/microsoft/react-native-windows-samples/tree/main/samples/NativeModuleSample/cppwinrt Can this example help? Sorry, I don't know C++ well enough

ospfranco commented 6 months ago

No idea buddy. I will probably not do this myself, no free time atm. Somebody else will have to take care of it.

maksimlya commented 1 month ago

@ospfranco any idea how much work is to add windows support?

ospfranco commented 1 month ago

Nope, I have never developed for windows

maksimlya commented 1 month ago

@ospfranco Hi, I can try adding windows support. Can you tell me how you built the jni libs(android), .a files(ios)? I noticed you have 2 versions, I did not find any make files.

ospfranco commented 1 month ago

Before you start developing this, I hope you realize will have to maintain the Windows versions for ever. The moment I change the API or do some breaking change I will not even try to take a look and try to make it work.

That being said, for any existing library file in the repo. You need to compile it in their source repo and then drop them here. You will probably need to compile crsqlite and libsql. crsqlite I cannot help, I just found some prebuilt binary and dropped it in the repo. For libsql turso paid me for development time to port to mobile platforms. Here are the instructions (link to the PR is inside) on how to compile libsql for mobile targets.