search

OP-TED / eForms-SDK

eForms is the notification standard for public procurement procedures in the EU. The eForms SDK is a collection of resources providing the foundation for building eForms applications.
Creative Commons Attribution 4.0 International
59 stars 31 forks source link

Faulty Group-Definitions in several Notice-Types. #870

Open duranalp opened 8 months ago

duranalp commented 8 months ago

We found different Group Definition GR-Procedure-Description in several Notice-Types. In our point of view, these group definition shall be same in all notice types.

We assume that the correct Definition is in Notice-Type 16.json

"id" : "GR-Procedure-Description",
        "contentType" : "group",
        "displayType" : "GROUP",
        "description" : "Description",
        "_label" : "group|name|GR-Procedure-Description",

In several Notice Types for e.g. Notice-Type 29.json the group is defined wrong

        "id" : "GR-Procedure-Description",
        "contentType" : "group",
        "nodeId" : "ND-ProcedureProcurementScope",
        "displayType" : "GROUP",
        "description" : "Scope of the Procurement addressed with the whole notice",
        "_label" : "group|name|ND-ProcedureProcurementScope"

We are using SDK 1.10.x we asking also for a patch of the SDK 1.10.x

duranalp commented 7 months ago

Hi i want to slightly ask if you have an update for this issue?

duranalp commented 7 months ago

Now 3 Weeks are gone, and i did not get any feedback. Why?

bertrand-lorentz commented 7 months ago

Sorry for the delayed response.

The difference is that in 29.json (and other notice subtypes), this group is associated with the node "ND-ProcedureProcurementScope". In 16..json it is not the case. This is indeed inconsistent. This association might not be correct, as there are fields under ND-ProcedureProcurementScope that are not shown under GR-Procedure-Description.

We will review this and correct it in a future SDK version.

GarrusMD commented 5 months ago

Is there an update for this issue?

GarrusMD commented 5 months ago

I have just seen that in the RC for 1.12 the label in subtype 16 has been changed:

"id" : "GR-Procedure-Description", "contentType" : "group", "nodeId" : "ND-ProcedureProcurementScope", "displayType" : "GROUP", "description" : "Scope of the Procurement addressed with the whole notice", "_label" : "group|name|ND-ProcedureProcurementScope",

In my opinion, this change is incorrect. The label "group|name|GR-Procedure-Description" should be the correct one for the "GR-Procedure-Description.

I agree with @duranalp that the flaw is in subtype 29 (and other notice subtypes).

GarrusMD commented 5 months ago

@bertrand-lorentz @YvesJo

YvesJo commented 4 months ago

Hi, Groups and associated labels are purely for the UI. As indicated in § 3.9 of the eForms Policy Implementation Handbook:

Labels are the texts used in user interfaces for manually filled fields. They are based on simplified eForms descriptions (parts of the descriptions appear as tooltips). The Publications Office of the EU will offer default set of labels in all EU official languages, used in the eNotices2 software application and in the TED website. Designers could make eProcurement systems more user-friendly by tailoring labels further. For example, labels can be tailored based on users (e.g. professional procurers may prefer legal terminology, SMEs and occasional procurers may prefer more user-friendly terminology), the system (e.g. form-filling vs. form-displaying), etc.

The most appropriate option has been selected given the constraints and the need to have this fixed for SDK 1.12. KR

GarrusMD commented 4 months ago

I understand that the labels are purely for the UI. But I am still of the opinion that nodeID and label were simply assigned incorrectly here. No information on tendering terms are recorded in this group.

GarrusMD commented 2 months ago

@bertrand-lorentz @YvesJo Can you please check my last comment. We are currently testing the SDK 1.12 and as I feared, the wrong name for the group "GR-Procedure-Description" is now displayed in all places.

YvesJo commented 1 month ago

Hi, There are fields in the description that depend on node ND-ProcedureProcurementScope and the node needs to be kept. The label for the group will be changed back to "Description"