OP-TED / eForms-SDK

eForms is the notification standard for public procurement procedures in the EU. The eForms SDK is a collection of resources providing the foundation for building eForms applications.
Creative Commons Attribution 4.0 International
59 stars 30 forks source link

incorrect label for rule BR-BT-00738-0053 #980

Open mdewinne opened 3 months ago

mdewinne commented 3 months ago

Citing the changelog of SDK 1.8.1:

  • Remove redundant rule checking that preferred publication date is after the dispatch date.
  • Correct rule BR-BT-00738-0053 to allow the preferred publication date (BT-738) to be equal to the dispatch date (BT-05).

The schematron seems to have been updated accordingly, but in rule_en.xml the error message for BR-BT-00738-0053 still reads: Preferred publication date' (BT-738-notice) must be between 2 and 60 days after 'Notice dispatch date'

YvesJo commented 3 months ago

Hi, The English version is indeed not aligned with the translations and this should get fixed with a next labels update.

mdewinne commented 3 months ago

@YvesJo Thx - as far as I can tell the issue also exists in the other languages.

YvesJo commented 3 months ago

Hi @mdewinne Extracting the labels for SDK 1.8.2, I get the following:

    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Предпочитана дата за публикуване' (BT-738-notice) трябва да бъде между 0 и 60 дни след 'Дата на изпращане на известието'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Preferované datum zveřejnění' (BT-738-notice) musí být v rozmezí od 0 do 60 dnů po 'Datum odeslání oznámení'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Foretrukken offentliggørelsesdato' (BT-738-notice) skal være mellem 0 og 60 dage efter 'Afsendelsesdato for bekendtgørelsen'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Bevorzugtes Datum der Veröffentlichung' (BT-738-notice) muss zwischen 0 und 60 Tage nach 'Datum der Übermittlung der Bekanntmachung' sein</entry>
    Line 17886: <entry key="rule|text|BR-BT-00738-0053">'Προτιμώμενη ημερομηνία δημοσίευσης' (BT-738-notice) πρέπει να είναι μεταξύ 0 και 60 ημερών μετά 'Ημερομηνία αποστολής της προκήρυξης'</entry>
    Line 25975: <entry key="rule|text|BR-BT-00738-0053">'Preferred publication date' (BT-738-notice) must be between 2 and 60 days after 'Notice dispatch date'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Fecha preferida de publicación' (BT-738-notice) debe situarse entre 0 días y 60 días después de 'Fecha de envío del anuncio'</entry>
    Line 17798: <entry key="rule|text|BR-BT-00738-0053">'Avaldamise eeliskuupäev' (BT-738-notice) peab olema 0 kuni 60 päeva pärast 'Teate saatmise kuupäev'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Ensisijainen julkaisupäivä' (BT-738-notice) on oltava 0 ja 60 päivän välillä 'Ilmoituksen lähetyspäivä' jälkeen</entry>
    Line 20106: <entry key="rule|text|BR-BT-00738-0053">'Date de publication souhaitée' (BT-738-notice) doit être compris entre zéro et soixante jours après 'Date d’envoi de l’avis'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Ní mór 'Dáta foilsithe is rogha leat' (BT-738-notice) a bheith idir 0 agus 60 lá tar éis 'Dáta seolta an fhógra'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Željeni datum objave' (BT-738-notice) mora biti između 0 i 60 dana nakon 'Datum slanja obavijesti'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'A hirdetmény közzétételének preferált dátuma' (BT-738-notice) 0–60 nappal 'A hirdetmény megküldésének dátuma' után kell, hogy legyen</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Data di pubblicazione preferita' (BT-738-notice) deve essere compreso tra 0 e 60 giorni dopo 'Data di trasmissione dell'avviso'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Pageidaujama paskelbimo data' (BT-738-notice) turi būti 0–60 dienų po 'Skelbimo išsiuntimo data'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Vēlamais publicēšanas datums' (BT-738-notice) jābūt no 0 līdz 60 dienām pēc 'Paziņojuma nosūtīšanas datums'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Data ta’ pubblikazzjoni preferuta' (BT-738-notice) irid ikun bejn jiem żero u 60 jum wara 'Data ta’ meta ntbagħat l-avviż'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Voorkeursdatum voor publicatie' (BT-738-notice) moet tussen 0 en zestig dagen na 'Verzenddatum van de aankondiging' zijn</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Preferowana data publikacji' (BT-738-notice) musi wynosić od 0 do 60 dni po 'Ogłoszenie – data wysłania'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Data de publicação preferida' (BT-738-notice) deve estar entre 0 e 60 dias após 'Data de envio do anúncio'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Data preferată pentru publicare' (BT-738-notice) trebuie să fie între 0 și 60 de zile după 'Data notificării expedierii'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Preferovaný dátum uverejnenia' (BT-738-notice) musí byť od 0 do 60 dní po 'Dátum odoslania oznámenia'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Zaželeni datum objave' (BT-738-notice) mora biti od 0 dni do 60 dni po 'Datum pošiljanja obvestila'</entry>
    Line 17781: <entry key="rule|text|BR-BT-00738-0053">'Önskat offentliggörandedatum' (BT-738-notice) måste vara mellan 0 och 60 dagar efter 'Avsändningsdatum för meddelandet'</entry>

and may only detect an issue for the EN label. Would you have additional information to share?

mdewinne commented 3 months ago

@YvesJo Ah yes, you are right. But then there may have been a regression, because in the latest version of the rule_language.xml files, the delay once again mentions "between 2 and 60 days".

E.g. rule_fr.xml in SDK 1.12: <entry key="rule|text|BR-BT-00738-0053">'Date de publication souhaitée' (BT-738-notice) doit être compris entre deux et soixante jours après 'Date d’envoi de l’avis'</entry>

YvesJo commented 3 months ago

indeed, following further investigations, some unexpecting and competing operations were carried out and led to regression in some recent SDKs. This is currently under investigation. Thanks for the details.