search

OP-TED / eForms-SDK

eForms is the notification standard for public procurement procedures in the EU. The eForms SDK is a collection of resources providing the foundation for building eForms applications.
Creative Commons Attribution 4.0 International
59 stars 30 forks source link

Vaildation fails if more than 6 digits are entered in field BT-36 #995

Closed GarrusMD closed 2 months ago

GarrusMD commented 3 months ago

We have noticed that the validation fails with a plain 500 error if 7 or more digits are entered in the BT-36-Lot or BT-36-Part field.

From a technical point of view, it does not seem sensible to enter more than 6 digits here, but this has already happened twice (in production) due to incorrect entries. From our point of view, it would therefore make sense to restrict the input via a pattern. Alternatively, there should at least be a meaningful error message.

YvesJo commented 3 months ago

Thanks for reporting that concern. We will discuss this internally to identify the available options.

bertrand-lorentz commented 2 months ago

The SDK does not impose any limit on the value in the BT-36-Lot or BT-36-Part field.

I was not able to reproduce the problem: validating a notice with the following value for BT-36-Lot did not cause any error:

<cbc:DurationMeasure unitCode="YEAR">12345678</cbc:DurationMeasure>

I was also able to submit this notice for publication in our test environment.

I assume that you got this error after trying to submit a notice via the API of eNotices2. So the error came probably from the eNotices2 application.

A new version of the application was deployed since your message, so the problem might already have been solved.

I'd suggest that you try to reproduce the problem in the Preview environment, and if you get the error, please contact the TED hepdesk (https://enotices2.ted.europa.eu/help/contact), explaining the steps you took and attaching the XML notice that caused the error.

As this does not seem to be an issue with the eForms SDK, I'm closing this.