OP-TED / ePO

The eProcurement Ontology provides the formal, semantic foundation for the creation and reuse of linked open data in the domain of public procurement in the EU.
European Union Public License 1.2
58 stars 18 forks source link

Questions on Durations for Lot and Contract To Be Checked #267

Closed giorgialodi closed 9 months ago

giorgialodi commented 3 years ago

I was analysing the OWL restriction file (version 2.0.1) for opening possible issues in case of strange things noticed.

My attention was caught by the property hasContractDuration between the Lot and the Period. The definition is "The estimated date when the contract is to be started."

Question: why is it called hasContractDuration if it is a property for the Lot? Shouldn't be for the Contract a property called hasContractDuration? In the name of the property the fact that is estimated is not captured. In addition it is a date, not a period, according to the definition. If we stick to the definition, something like hasContractEstimatedStartingDate seems more inline (which i s a xsd:date not a period). What do you think about it?

SellittoGiampaolo commented 3 years ago

A Lot usually generates a contract, which in turn has an expected duration. The contract duration must be linked to the specific lot, since you can have lots with different duration and different starting dates These properties are already known before the call for tender and are part of the information that must be published, so they are properly comprised in the information known before the contract is signed - the piece of information regarding the contract is filled at a later date, and it would not be possible to include the length of the contract when you do not have the core information in place. I think that the modeling is correct.

ec-mcs commented 3 years ago

How would it be for a DPS where you naturally have many contracts per lot? Or how about mini-tenders for FA?

giorgialodi commented 3 years ago

Sorry, probably I was not able to express myself correctly. I am not suggesting to remove the property. I am just suggesting that a better naming can be possible, that can represent what is included in the current definition for that property; that is, the fact that it is an estimated starting date. For me "hasContractDuration" recalls the duration (start date and end date) of a contract (signed). It was anyway a question :)

SellittoGiampaolo commented 3 years ago

@ec-mcs In the DPS we track:

paulakeen commented 3 years ago

The properties between Contract, Lot and Period need to be reviewed since the predicates do not make sense in some cases. For example, in "Contract hasEvaluationDuration Period", and other... (contracts are not evaluated, but lots are). Other issues with these properties may also exist.

andreea-pasare commented 1 year ago

At the moment, there is a relation from Contract to Duration, epo:hasEstimatedDuration: image

The definition for this relations was changed to Relation indicating a Contract has an estimated Duration. This is related to #416 and will be further investigated in the near future.

muricna commented 1 year ago

If the definication is indicating a Contract has an estimated Duration the reuse of this predicate is not possible.

andreea-pasare commented 1 year ago

@muricna Should we also change the name of the predicate to epo:hasContractEstimatedDuration? Also, do we want this relation moved at the level of the ContractTerm since we have the following relations from ContractTerm: image

muricna commented 1 year ago

If it is at ContractTerm level I am not sure it is need in the contract