OP-TED / ePO

The eProcurement Ontology provides the formal, semantic foundation for the creation and reuse of linked open data in the domain of public procurement in the EU.
European Union Public License 1.2
58 stars 18 forks source link

epo:hasMainActivity codelist, example, domain #396

Open VladimirAlexiev opened 1 year ago

VladimirAlexiev commented 1 year ago

epo:hasMainActivity is defined as "The principal sectoral area in which an organisation operates.\n\nAdditional information:\n\nThe activities associated with buyers are derived from the top level of the Classification of the functions of the government (COFOG) from the United Nations Statistics Division.\n\nThe activities associated with buyer are derived from sectors explicitly falling within the sectoral directive (2014/25/EU Art. 8 - Art. 14).\n\nWG Approval 05/05/2020\n\nThe codelist to be used is at-voc:main-activity which is available at http://publications.europa.eu/resource/dataset/main-activity (org:Organization -> at-voc:main-activity (+epo:hasMainActivity)) "@en ;

However:

Please:

VladimirAlexiev commented 1 year ago

397 is very similar

andreea-pasare commented 6 months ago

The codelists are just recommendations in the ePO UML diagrams, therefore all reference to codelists in the machine readable files have been removed.

VladimirAlexiev commented 5 months ago

@andreea-pasare I'm not sure what you wrote is true, the two fields still refer to codelists: https://github.com/search?q=repo%3AOP-TED%2FePO+epo%3AhasMainActivity&type=code

But it was true, it would be akin to "dereliction of duty": you define a field that should have values according to some EU directive, OPOCE seems to publish such a list, and yet your field fails to reference the list?

And how about defining a domain? Isn't that important?

andreea-pasare commented 5 months ago

@VladimirAlexiev, thank you for your reply. This seems to be a change that needs to be done in model2owl. I added a ticket there regarding this request:

VladimirAlexiev commented 5 months ago

Should you not keep this issue open until https://github.com/OP-TED/model2owl/issues/198 is fixed, and then this one is fixed too?

And how about defining a domain? Isn't that important?

andreea-pasare commented 5 months ago

@VladimirAlexiev,

Regarding the domain question, my bad, I completely forgot to answer in my previous comment. The domain and range are defined in the restrictions file: https://github.com/OP-TED/ePO/blob/ff440967f15132e53f823a502897f17e1ceefa54/implementation/ePO_core/owl_ontology/ePO_core_restrictions.ttl#L459-L460

I am re-opening this issue until the one in model2owl is fixed. Then we will proceed with resolving this issue as well.