search

OP-TED / ePO

The eProcurement Ontology provides the formal, semantic foundation for the creation and reuse of linked open data in the domain of public procurement in the EU.
European Union Public License 1.2
58 stars 18 forks source link

change `rdfs:Literal` to `rdf:PlainLiteral` #405

Closed VladimirAlexiev closed 7 months ago

VladimirAlexiev commented 1 year ago

You use rdfs:Literal for string fields. However, that datatype is overly wide. You won't be happy about a company name having values like:

Please use rdf:PlainLiteral instead, which in effect is a union of xsd:string and rdf:langString. See the spec: https://www.w3.org/TR/rdf-plain-literal/

AchillesDougalis commented 7 months ago

In the glossary of ePO 4.0.0 there are only rdf:PlainLiteral and not rdfs:Literal.

VladimirAlexiev commented 5 months ago

https://github.com/search?q=org%3AOP-TED+rdfs%3ALiteral&type=code shows 30 occurrences of rdfs:Literal:

Commits that make such a change:

@AchillesDougalis , you trust that Glossary too much! Please reopen.

andreea-pasare commented 5 months ago

@VladimirAlexiev, indeed, we do have some occurrences of rdfs:Literal in all OP-TED repositories, and in ePO we only have it mentioned in the model2owl-config folders, in config-parameters.xsl files (https://github.com/search?q=repo%3AOP-TED%2FePO++rdfs%3ALiteral&type=code). Those are variables that are not used anymore by model2owl when generating the RDF outputs for ePO.

We do want to have a proper clean-up of the entire model2owl configuration files in the ePO repository in a future release and it will be tracked in a separate discussion: https://github.com/OP-TED/ePO/discussions/588 (from which we will create an appropriate github issue once we get started). So thank you for this feedback, I will make sure to add it in our discussion.

Regarding the other issue (https://github.com/OP-TED/ePO/issues/447) it was converted into a discussion, but in my opinion we should also close that since it became a discussion about a different repository (https://github.com/OP-TED/ted-rdf-mapping) and an appropriate issue to track it was created: https://github.com/OP-TED/ted-rdf-mapping/issues/407.

VladimirAlexiev commented 5 months ago

@andreea-pasare

in ePO we only have it mentioned in the model2owl-config folder

That's not true, there are numerous semantic files with this defect. Here are the number of occurrences:

There are also numerous occurrences in EA.html files, i.e. directly in the UML models (cc @costezki).

I'm happy if this will be addressed in https://github.com/OP-TED/ted-rdf-mapping/issues/407

andreea-pasare commented 5 months ago

@VladimirAlexiev, the files mentioned above are not part of the ePO repository and:

Thank you for catching this :) Both of those projects would benefit from having general "clean-up repository" tickets as we have in ePO, so I will make sure to sync with them on this topic.

VladimirAlexiev commented 5 months ago

Thanks for the clarification! For the record, here are the occurrences of rdf:PlainLiteral: