OP-TED / eforms-notice-viewer

This is a sample eForms application that can visualise an eForms notice. It uses efx-toolkit-java to generate XSL templates from notice view templates written in EFX. It then uses an XSLT processor to generate an HTML visualisation of any given eForms notice.
https://docs.ted.europa.eu/eforms-common/notice-viewer/index.html
European Union Public License 1.2
10 stars 2 forks source link

add params to the command line for choosing the destination filename #81

Closed wanao-jd closed 9 months ago

wanao-jd commented 1 year ago

actually the output file is generated in the directory build\output-html\.html

it is better if we could choose the destination filename like this java -jar eforms-notice-viewer--app.jar -i summary en eforms-sdk/1.0/examples/notices/cn_24_minimal.xml -d d:\desttination\myfile.html

ciocan commented 11 months ago

+1

rousso commented 9 months ago

Hi @wanao-jd, @ciocan

This is a sample application, and its purpose is to demonstrate how to use the SDK and the EFX Toolkit to visualise a notice. Although we agree that the feature you propose would be nice to have, we need to maintain our focus in the current priorities, so I cannot make any promises for this one right now.

It seems like an easy thing to implement though. Any chance either of you implements this and sends us a pull-request? We will be happy to review it and merge it!

Thank you for your understanding, Yannis

cc: @bertrand-lorentz