search

OP-TED / eforms-notice-viewer

This is a sample eForms application that can visualise an eForms notice. It uses efx-toolkit-java to generate XSL templates from notice view templates written in EFX. It then uses an XSLT processor to generate an HTML visualisation of any given eForms notice.
https://docs.ted.europa.eu/eforms-common/notice-viewer/index.html
European Union Public License 1.2
10 stars 2 forks source link

overload constructor of TranslationUriResolver #94

Closed papacst closed 3 months ago

bertrand-lorentz commented 4 months ago

I don't understand why this is needed. The caller can just convert to a Path themselves: ... = new TranslationUriResolver(version, Path.of(someString))

papacst commented 4 months ago

Notice Viewer is mainly used as a library (at least in MDM). Such polymorphism with overloaded constructors is quite common in libraries. When coding for MDM, I run into this (holding a Path instead of string), so my reaction was to overload it (that caused the issue with diff in jar from maven - I had totally forgotten it :) )