Closed csnyulas closed 1 year ago
Fixed in CM version 4.1.0. Technical mapping needs to be implemented.
This issue has been fixed as proposed (i.e. by linking the Channel to the Procedure, instead of the Organization). However, I would not close this issue until it is confirmed that this will remain the final solution, by considering the following questions/potential problems:
Questions:
CONTRACTING_BODY/URL_TOOL
paths in the data? Which one should be linked to the Procedure? Or should we link multiple channels to the Procedure? Which one is the "good" one? We haven't found such data in our testing sample (except once, see below), but according to the XSD such situation can arrise, and would be valid. The only place where we have multiple URL_TOOL
elements is in notice 357454-2021.xml (which is an F08 form in the sampling_2014_2022/R2.0.9.S04.E01
folder), but here the URLs are on different root elements, where one is the translation of the other.URL_TOOL
on the Buyer organization, but we don't have Section IV, for Procedure? (e.g. 172624-2021.xml) Hopefully @muricna or @andreea-pasare or @costezki can help answering the above questions.
If the hasAdhocURL is used for this mapping then there is no problem for other URLs. F08 does have a section for procedures see: Section II.1 If it is not clear that section II.1 is for procedure and II.2 for lot in all forms maybe we need a meeting to explain the forms
Why has the ADhocURL not been used as requested?
We seem to be missing the above stated solution of connecting the Channel to the Procedure. (e.g. 601452-2021)
After having a discussion in eOrdering the WG realised and decided that a channel shall be linked to the Organisation (or rather it's Role). So, it appears that the original mapping of section I.3.5 of delivery Channel to Organisation was correct.
We closed this issue as, after further discussion with @muricna and @costezki, we agreed that the URL_TOOL
is not on the organization, but belongs to the procedure, and it is not a repeatable element, except perhaps with the same value when there are multi-lingual notices (as we found in 357454-2021
). So, the current implementation is good. There is nothing to be added or changed.
In fact, we did some improvements. As it can be seen in the referenced commits, we have:
tedm:OrganisationChannel
to tedm:ElectronicCommunicationChannel
) to avoid any possible confusion;epo:hasDeliveryGateway
gateway to this Channel from the BuyerOrganisationGroup, which was left there probably due to an oversight, when the channel was attached to the Procedureepo:isAdhocChannel
property value for this Channel to true
.The conceptual mapping file needs to be updated to reflect this update that the epo:isAdhocChannel is used.
context F21
Should be changed to: