OP-TED / ted-rdf-mapping

Transformation rules and other artefacts for the TED Semantic Web Services
European Union Public License 1.2
8 stars 1 forks source link

URI duplication #292

Closed muricna closed 1 year ago

muricna commented 1 year ago

II.2.3.2: 20375 -2021 there are 2 lots both have 2 URIs for this concept where as the xml has 1 instance for each

V.0.1: The contract number repeats 6 times per contract see 287882-2021 with separate URIs

costezki commented 1 year ago

A contract shall have a single ID

image

costezki commented 1 year ago

locn:address seems to be duplicated, for unknown reason.

image

csnyulas commented 1 year ago

The first part of the issue, presented in more detail in he above comment (about incorrect join of ContractTermLocationAddress) has has been fixed in commit f028b3541fade4e9cc79972dc3ae26f31b32c95e, and it is part of the tx1.4.beta tag:

https://github.com/OP-TED/ted-rdf-mapping/blob/3c0d4fb7706a991650ac056aba0a9418fb0f9a78/mappings/package_F06/output/020375-2021/020375-2021.ttl#L56-L62

The second part of the issue (about the repeating ContractIdentifiers, all with the same contract number being attached to the contract where any one of them belongs) was fixed in the above referenced commit. Now for any repeating contract number there is only one ContactIdentifier instance is created, and that same instance may be referred from multiple Contract instances, where they belong.

valexande commented 1 year ago

@muricna Natalie sry for bothering, can I ask why was this issue re-opened?

muricna commented 1 year ago

@valexande I think it was an error of manipulation sorry for the inconvenience. I will reclose the ticket.

valexande commented 1 year ago

Thanks for the response Natalie :) @muricna