search

OP-TEE / build

Makefiles to use OP-TEE on various platforms
107 stars 209 forks source link

QEMU enablement for Trusted Services #688

Closed stormset closed 6 months ago

stormset commented 9 months ago

Add new build files to configure OP-TEE and TF-A for the S-EL1 SPMC scenario on QEMU platform for Trusted Services.

jenswi-linaro commented 9 months ago

I'm going to ask you the same thing as I asked the author of https://github.com/OP-TEE/build/pull/686 before he closed that PR.

It would be nice with a bit of background to this. Do you represent a company? Are you going to maintain this? Do you expect to contribute more?

stormset commented 9 months ago

Hi! I was working at Arm recently on the TS project. I left, so I am making these contributions privately. I am available to maintain it and make other contributions. I thought it would be great to be able to use the project on QEMU too, instead of the proprietary FVP.

jenswi-linaro commented 9 months ago

Got it, thanks for contributing.

jenswi-linaro commented 9 months ago

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

github-actions[bot] commented 8 months ago

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed pull request at any time.

jforissier commented 8 months ago

@stormset do you plan to address the review comments? Thanks.

stormset commented 8 months ago

@stormset do you plan to address the review comments? Thanks.

Hi! I'm really sorry for the delay. I noticed another issue with the PR, namely the handling of the reserved memory location (for the carveout) in the device tree. I have a solution that dumps out the device tree (which is generated by QEMU when the 'virt' platform is used) and passes the modified one to QEMU. Looking at this patch, I don't see any better solution. I still haven't tested it properly, but I will do it this week and also address the other comments.

jforissier commented 8 months ago

@stormset do you plan to address the review comments? Thanks.

Hi! I'm really sorry for the delay. I noticed another issue with the PR, namely the handling of the reserved memory location (for the carveout) in the device tree. I have a solution that dumps out the device tree (which is generated by QEMU when the 'virt' platform is used) and passes the modified one to QEMU. Looking at this patch, I don't see any better solution. I still haven't tested it properly, but I will do it this week and also address the other comments.

Thanks for the update. Given what I could read in the qemu-devel thread, I think your approach of dumping the QEMU-generated DT and modifying it is sensible, however it should be done at runtime so that the base DT file does not need to be maintained as QEMU evolves. A similar suggestion was made in another PR by the way (https://github.com/OP-TEE/build/pull/695#issuecomment-1801336966).

stormset commented 7 months ago

Addressed the mentioned issue, also rebased.

github-actions[bot] commented 6 months ago

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed pull request at any time.