search

OP-TEE / build

Makefiles to use OP-TEE on various platforms
107 stars 209 forks source link

make: change from localhost to 127.0.0.1 #692

Closed jbech-linaro closed 9 months ago

jbech-linaro commented 9 months ago

Depending on how to you connect to internet, the tcp.localhost might not always work. You can eventually end up with the following error message:

(qemu) qemu-system-aarch64: -serial tcp:localhost:54320: Failed to connect to 'localhost:54320': Connecti on refused qemu-system-aarch64: -serial tcp:localhost:54320: could not connect serial device to character backend 't cp:localhost:54320'

Therefore it's better to instead use 127.0.0.1 when connecting to the serial consoles.

FYI, this just happened to me when being at the osfc.io conf. I first couldn't figure out why the "make-run" didn't work. Then I tried disable my WiFi connection and things worked as expect. But to avoid this, as said in the commit message, I think it's better to use 127.0.0.1 instead.

jforissier commented 9 months ago

Sounds reasonable, although I would think localhost should always resolve to 127.0.0.1.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

etienne-lms commented 9 months ago

I have no strong opinion on which of 127.0.0.1 or localhost is better. That said, Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> with qemu.mk also updated.

jenswi-linaro commented 9 months ago

Haha, reminds me of an issue I have at home with a Samsung TV trying to claim localhost as its hostname. Internet of stupid things, here we come! :-) Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

jbech-linaro commented 9 months ago

Commit message updated and qemu.mk changed as well (Thanks Etienne!).

Squashed, rebased and tag(s) applied (should be) ready for merge! Thanks!