search

OP-TEE / build

Makefiles to use OP-TEE on various platforms
107 stars 209 forks source link

stm32mp1: *_SCMI flavor for STM32MP15 ST boards #711

Closed etienne-lms closed 5 months ago

etienne-lms commented 7 months ago

Define 157x_xxx_SCMI platform flavors for STM32MP15 ST boards where RCC secure hardening is enabled and non-secure needs to use SCMI service. These are board DTS file ending with -scmi.dts.

The default stm32mp1 platform flavor is now 157C_DK2_SCMI.

This change depends on https://github.com/OP-TEE/optee_os/pull/6541.

GseoC commented 7 months ago

Hi, Ok for the most part but there's a mix between '-' and '_' in the file names that is not present for the device tree files. Can you correct this please? e.g: DK1_SCMI

etienne-lms commented 7 months ago

I have simplified the picture here. The 2 first commits remove the various genimage config files and bootfs file tree overlays and replaces them by files generated at build time (modif dine in boards post-image.sh shell script).

The 3rd patch defined 157x_XXX_SCMI platform flavors for the config related to stm32mp15*-scmi.dts board files.

github-actions[bot] commented 6 months ago

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed pull request at any time.

etienne-lms commented 6 months ago

@GseoC, could you look back to these changes?

etienne-lms commented 5 months ago

I've addressed comment (s/TFA_VERSION/TFA_BOARD_REV/g) and applied the review tag. Thanks.

etienne-lms commented 5 months ago

@jforissier, ok to merge these before next release tag? This change syncs build.git/stm32mp1.mk with _opteeos regarding platform flavor names.

etienne-lms commented 5 months ago

Note: OP-TEE OS needs a fixup, see https://github.com/OP-TEE/optee_os/pull/6620.

jforissier commented 5 months ago

@jforissier, ok to merge these before next release tag? This change syncs build.git/stm32mp1.mk with _opteeos regarding platform flavor names.

It's a bit more than a bug fix so it should normally not go after -rc1 with the risk it could break things for stm32... But if you say you're OK with that, then fine.