buildroot: add $HOME/.cargo/bin to $PATH prior to building

OP-TEE / build

Makefiles to use OP-TEE on various platforms

106 stars 209 forks source link

buildroot: add $HOME/.cargo/bin to $PATH prior to building #724

Closed jforissier closed 5 months ago

jforissier commented 5 months ago

Since commit e742dc88f51c ("qemu_v8: Enable Rust examples build by default"), the 'cargo' command installed by the optee-rust target needs to be in the $PATH or the Rust examples will fail to build.

jforissier commented 5 months ago

Updated

b49020 commented 5 months ago

@jforissier @jenswi-linaro

Do you mean that optee-rust should use a more specific path to install the toolchain?

I'm sorry, I missed your comment. Yes, I believe a more safe choice would be to install the rust toolchain under the $(ROOT)/toolchains directory.

https://github.com/OP-TEE/build/pull/725 implements this. Changes in this PR looks good to me as well, if you would like to merge it first then feel free to apply:

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

jforissier commented 5 months ago

@b49020 thanks, but let's drop this in favor of #725.