Refactor helper macros and add uefi authenticated variables related build settings

OP-TEE / build

Makefiles to use OP-TEE on various platforms

106 stars 209 forks source link

Refactor helper macros and add uefi authenticated variables related build settings #733

Closed gabor-toth-arm closed 4 months ago

gabor-toth-arm commented 5 months ago

Hi guys!

Could you send me some information about the IBART failure? I can't see the logs.

Thanks!

jforissier commented 5 months ago

@gabor-toth-arm the IBART error doesn't look related to this change. It is a Buildroot caching issue, I guess triggered by the recent Buildroot update (https://github.com/OP-TEE/manifest/commit/9e89bc56fd6e2d3da27213afd32ac8c7019e4642).

  3513:  2024-02-06 14:14:28 (2,21 MB/s) - ‘/dev/shm/qemu/out-br/build/.hiredis-1.2.0.tar.gz.MY0KEq/output’ saved [126216/126216]
  3514:  
  3515:  hiredis-1.2.0.tar.gz: OK (sha256: 82ad632d31ee05da13b537c124f819eb88e18851d9cb0c30ae0552084811588c)
  3516:  mktemp: failed to create file via template ‘/mnt/storage/buildroot_cache/download/hiredis/hiredis-1.2.0.tar.gz.XXXXXX’: Permission denied
  3517:  make[2]: *** [package/pkg-generic.mk:179: /dev/shm/qemu/out-br/build/host-hiredis-1.2.0/.stamp_downloaded] Error 1

gabor-toth-arm commented 5 months ago

ts: fix build-ts-app helper macro": Correct adding extra flags to the CROSS_COMPILE settings

OK

and replace dashes with underscore in variables to follow the common coding scheme.

That I can't see in the patch.

Yes, sorry. That has been removed from this change.

jforissier commented 5 months ago

ts: fix build-ts-app helper macro": Correct adding extra flags to the CROSS_COMPILE settings

OK

and replace dashes with underscore in variables to follow the common coding scheme.

That I can't see in the patch.

Yes, sorry. That has been removed from this change.

FWIW I like the dashes ;)

jforissier commented 5 months ago

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

gabor-toth-arm commented 4 months ago

Hi!

Do you have any news about the failure? Is it fixed?

jbech-linaro commented 4 months ago

Do you have any news about the failure? Is it fixed?

I fixed IBART errors the other day showing up an all builds. Since then it's been running as expected. Let me restart the build for this one and hopefully that should be fine as well.

jbech-linaro commented 4 months ago

Do you have any news about the failure? Is it fixed?

I fixed IBART errors the other day showing up an all builds. Since then it's been running as expected. Let me restart the build for this one and hopefully that should be fine as well.

Unfortunately this particular build still fails. It's not obvious to me what the problem is, but since all other PR's seems to pass I suspect there is something in your branch triggering something. Not sure if we've done changes that requires a rebase on your own branch. If you haven't done that, then that's another thing to try. I.e., rebase to master and force push.

gabor-toth-arm commented 4 months ago

Do you have any news about the failure? Is it fixed?

I fixed IBART errors the other day showing up an all builds. Since then it's been running as expected. Let me restart the build for this one and hopefully that should be fine as well.

Unfortunately this particular build still fails. It's not obvious to me what the problem is, but since all other PR's seems to pass I suspect there is something in your branch triggering something. Not sure if we've done changes that requires a rebase on your own branch. If you haven't done that, then that's another thing to try. I.e., rebase to master and force push.

Thanks, it works now :)