search

OP-TEE / build

Makefiles to use OP-TEE on various platforms
109 stars 215 forks source link

Add imx8mp support #742

Closed fboudra closed 5 months ago

fboudra commented 6 months ago

This serie add support for imx8mp-evk and imx8mp-verdin boards. It has some prep patches followed by board specific config snippets to leverage imx.mk Makefile.

fboudra commented 6 months ago

@jforissier PR updated. Comments should have been addressed.

jforissier commented 6 months ago

LGTM, please add Acked-by: Jerome Forissier <jerome.forissier@linaro.org> to the remaining commits. Thanks!

jenswi-linaro commented 5 months ago

With this how should imx-mx8mqevk be compiled? Without any extra it doesn't boot. With make all IMX_BOARD=imx8mp-evk it fails to compile with:

make[1]: Leaving directory '/home/jens/work/repos/imx/trusted-firmware-a'
# Copy DDR4 firmware
cp /home/jens/work/repos/imx/build/../out-firmware/firmware-imx-8.10.1/firmware/ddr/synopsys/lpddr4_pmu_train_*.bin \
    /home/jens/work/repos/imx/build/../u-boot
cp: cannot stat '/home/jens/work/repos/imx/build/../out-firmware/firmware-imx-8.10.1/firmware/ddr/synopsys/lpddr4_pmu_train_*.bin': No such file or directory
jenswi-linaro commented 5 months ago

I tried a make clean followed by make all IMX_BOARD=imx8mp-evk and it compiles now, but it still doesn't boot.

jenswi-linaro commented 5 months ago

I tried cloning a fresh repo and just a make all and now it works. There must have been some build artifact from the previous build from the build master branch. It's a pity it's so fragile. I don't know how to fix it, since I don't know which is the troublesome file.

jenswi-linaro commented 5 months ago

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

jforissier commented 5 months ago

@fboudra please add Jens' tag and I will merge this. Thanks.

fboudra commented 5 months ago

@jforissier done. Added Jen's tag and repushed. Thanks.