search

OP-TEE / build

Makefiles to use OP-TEE on various platforms
109 stars 219 forks source link

Issues building for `rpi3` on Aarch64 Debian Bookworm. #775

Closed msgilligan closed 2 months ago

msgilligan commented 3 months ago

I was able to successfully build an SDCard image on Debian Bookworm (in a MacOS AArch64 VM) but ran into 3 minor issues:

  1. The official instructions say to do make -j8 followed by make img-help, but the output of make img-help is incorrect because ../out/rpi3-sdcard.img has not been built yet. You must do a make sdcard-image to build that file.

Update: This is incorrect. Now that (2) and (3) are fixed the default make target is building sdcard-image.

  1. When running make sdcard-image the following warning message is emitted:
../toolchains/aarch64/bin/aarch64-linux-ld.bfd: warning: trusted-firmware-a/build/rpi3/debug/bl1/bl1.elf has a LOAD segment with RWX permissions

I was able to work-around this error by making the following change in trusted-firmware-a/Makefile:

-TF_LDFLAGS             +=      --fatal-warnings -O1
+TF_LDFLAGS             +=      --no-fatal-warnings -O1

There's probably a cleaner fix that resolves the warning and leaves warnings as fatal. But this workaround allows the image to be built and the resulting image successfully boots my Rpi3 and can run xtest.

  1. I had to add /usr/sbin to my shell's $PATH or otherwise make sdcard-image would fail to find fdisk and mkdosfs.
jbech-linaro commented 3 months ago
  1. The official instructions say to do make -j8 followed by make img-help, but the output of make img-help is incorrect because ../out/rpi3-sdcard.img has not been built yet. You must do a make sdcard-image to build that file.

That implies that something went wrong with the overall build. You can definitely call sdcard-image by itself, but that target is called as a dependency from the all makefile rule. What I'm saying is that when the build is working as expected, there should be no need to explicitly call sdcard-image. I.e., we should fix the build errors and then this should just work. I.e., the instruction from the docs and make img-help are correct.

Personally I think it's overkill, but one could add to make img-help an if/else. I.e., pseudo if sdcard image exists, $sudo dd if .... else echo SD-image hasn't been generated. I'm not going to add that myself, but if someone else think it makes life easier for debugging build issues, than I'd be happy to accept a patch for it.

msgilligan commented 3 months ago
  1. The official instructions say to do make -j8 followed by make img-help, but the output of make img-help is incorrect because ../out/rpi3-sdcard.img has not been built yet. You must do a make sdcard-image to build that file.

That implies that something went wrong with the overall build.

You are right. I must have not noticed that the overall build had failed. Now that (2) and (3) are fixed, the overall build is in fact building rpi3-sdcard.img.

github-actions[bot] commented 2 months ago

This issue has been marked as a stale issue because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.