OP-TEE / manifest

Manifests to use OP-TEE on various platforms
65 stars 173 forks source link

Refactor manifests/avoid duplication #262

Closed igoropaniuk closed 7 months ago

igoropaniuk commented 8 months ago
  1. Use common repositories defined in common.xml manifest to avoid code duplication.
  2. Drop manifest for Verdin iMX8M Mini, as it's not maintained anymore.
jenswi-linaro commented 8 months ago

I'd rather wait with an eventual refactoring of the manifest until after the release.

jforissier commented 8 months ago

I'd rather wait with an eventual refactoring of the manifest until after the release.

Agreed. As usual, and since -rc1 has been tagged already, I will only merge fixes.

jbech-linaro commented 8 months ago

I'm OK with these changes and it's a nice clean up. But at the same time, if we for any reason in the future would need to move something to a specific git commit for a particular device, then we cannot do that as easy any longer. For that you'd have to use a local manifest, that works locally. However, historically we haven't had that happen a lot, so again, I'm OK with this, so please use my RB tag.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

jenswi-linaro commented 8 months ago

You're supposed to be able to override what's in a previously included file. See for example fvp-ts.xml.

jbech-linaro commented 8 months ago

You're supposed to be able to override what's in a previously included file. See for example fvp-ts.xml.

OK, then I have no concerns. Thanks!

etienne-lms commented 8 months ago

My bad, optee_benchmark is listed in common.xml.

Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> for commit "common: use common manifest to avoid code duplication".

igoropaniuk commented 8 months ago

@etienne-lms I'll drop optee_manifest in a separate PR

igoropaniuk commented 7 months ago

Addressed @jenswi-linaro comment, applied tags from @jbech-linaro @etienne-lms , rebased. thanks!

jenswi-linaro commented 7 months ago

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

igoropaniuk commented 7 months ago

@jenswi-linaro tag applied. I've just stumbled upon another issue, rpi3 was using optee branch instead of rpi3-optee-6.7, this is fixed already