Closed igoropaniuk closed 10 months ago
I'd rather wait with an eventual refactoring of the manifest until after the release.
I'd rather wait with an eventual refactoring of the manifest until after the release.
Agreed. As usual, and since -rc1 has been tagged already, I will only merge fixes.
I'm OK with these changes and it's a nice clean up. But at the same time, if we for any reason in the future would need to move something to a specific git commit for a particular device, then we cannot do that as easy any longer. For that you'd have to use a local manifest, that works locally. However, historically we haven't had that happen a lot, so again, I'm OK with this, so please use my RB tag.
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
You're supposed to be able to override what's in a previously included file. See for example fvp-ts.xml
.
You're supposed to be able to override what's in a previously included file. See for example
fvp-ts.xml
.
OK, then I have no concerns. Thanks!
My bad, optee_benchmark is listed in common.xml.
Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
for commit
"common: use common manifest to avoid code duplication".
@etienne-lms I'll drop optee_manifest in a separate PR
Addressed @jenswi-linaro comment, applied tags from @jbech-linaro @etienne-lms , rebased. thanks!
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
@jenswi-linaro tag applied. I've just stumbled upon another issue, rpi3 was using optee
branch instead of rpi3-optee-6.7
, this is fixed already