search

OP-TEE / optee_docs

This git contains the official documentation for the OP-TEE project
BSD 2-Clause "Simplified" License
58 stars 96 forks source link

architecture: porting_guidelines: Expand section about RNG #162

Closed hoiho-amzn closed 2 years ago

hoiho-amzn commented 2 years ago

For vendors porting their RNG drivers to OP-TEE, it is important that both hw_get_random_byte() and crypto_rng_read() should be overriden for optimal performance if the hardware entropy source supports getting multiple bytes at a time.

etienne-lms commented 2 years ago

Hello @hoiho-amzn, P-R https://github.com/OP-TEE/optee_os/pull/5300 is under review and almost finalized. Once merged, platforms are required to only implement function hw_get_random_bytes(). I think we should update the doc on that basis, once the P-R is merged.

hoiho-amzn commented 2 years ago

Sounds good - thanks for pointing out!

github-actions[bot] commented 2 years ago

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

etienne-lms commented 2 years ago

Keep alive, it would be nice doc is updated. @hoiho-amzn, now that https://github.com/OP-TEE/optee_os/pull/5300 is merged, do you want to update this P-R (#162) accordingly?

hoiho-amzn commented 2 years ago

Ack - Will work on this after I am back from vacation later this week.

hoiho-amzn commented 2 years ago

Done

jforissier commented 2 years ago

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

jbech-linaro commented 2 years ago

@hoiho-amzn , I'll merge as soon as you've added @jforissier tag.

etienne-lms commented 2 years ago

@hoiho-amzn, don't forget to add your Signed-off-by tag in the commit message. Acked-by: Etienne Carriere <etienne.carriere@linaro.org>.

hoiho-amzn commented 2 years ago

All necessary tags added. Thanks!