Use key id as --id instead of key label

OP-TEE / optee_docs

This git contains the official documentation for the OP-TEE project

BSD 2-Clause "Simplified" License

58 stars 96 forks source link

Use key id as --id instead of key label #246

Closed citypw closed 2 weeks ago

citypw commented 3 weeks ago

Fix #245

etienne-lms commented 2 weeks ago

By the way, typo in commit message. Link: should be followed by an URL, not by string #245 followed by the Issue URL. Could you also remove the unless empty line between the Link: tag and S-o-b tag? (sorry bothering you with that).


-Link: #245: https://github.com/OP-TEE/optee_docs/issues/245
+Link: https://github.com/OP-TEE/optee_docs/issues/245
-
 Signed-off-by: Shawn Chang <citypw@hardenedlinux.org>

citypw commented 2 weeks ago

Done, plz review!

jforissier commented 2 weeks ago

LGTM and tested again OK

citypw commented 2 weeks ago

Some comment on the commit message: Replace which with where or with which. Rephrase "You can use key LABEL like -key pkcs11:object= only if the key were created with key ID.". I would raher say: "Key can be found by openssl tool from its label (e.g. -key pkcs11:object=) but the key still needs to be have also a key ID attribute unless what openssl may trigger a segmentation fault."

Done.

citypw commented 2 weeks ago

Done. Btw, the OpenSSL bug will be fixed in https://github.com/openssl/openssl/pull/25496