OP-TEE / optee_docs

This git contains the official documentation for the OP-TEE project
BSD 2-Clause "Simplified" License
58 stars 96 forks source link

Add ccache and python-pyelftools to prerequisites #27

Closed jenswi-linaro closed 5 years ago

jenswi-linaro commented 5 years ago

Adds the packages ccache and python-pyelftools to prerequisites.

Signed-off-by: Jens Wiklander jens.wiklander@linaro.org

jforissier commented 5 years ago

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

Is ccache a strong prerequisite? Technically, it should be optional, but it's so good that we probably want to have it in the list anyways ;-)

Regarding pythong-pyelftools, maybe state where it is used. I guess it's in commit ("core: embed ldelf into tee core") from PR https://github.com/OP-TEE/optee_os/pull/3036?

jbech-linaro commented 5 years ago

Is ccache a strong prerequisite? Technically, it should be optional, but it's so good that we probably want to have it in the list anyways ;-)

+1 for having ccache in the list. It's a bit like order a pizza, cheese is optional, but it's always included by default ;-)

jenswi-linaro commented 5 years ago

"core: embed ldelf into tee core" isn't merged yet, should we hold this off until it is?

jbech-linaro commented 5 years ago

"core: embed ldelf into tee core" isn't merged yet, should we hold this off until it is?

Yes, I think so.

jbech-linaro commented 5 years ago

@jenswi-linaro , since we've gotten the actual patches for the stuff merged, time to merge this. Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

jenswi-linaro commented 5 years ago

Tags applied, added a note on the python-pyelftools prerequisite.