search

OP-TEE / optee_docs

This git contains the official documentation for the OP-TEE project
BSD 2-Clause "Simplified" License
58 stars 96 forks source link

Update prerequisites.rst #32

Closed cevatbostancioglu closed 5 years ago

cevatbostancioglu commented 5 years ago

rsync dependency error solved.

jforissier commented 5 years ago

Hi @cevatbostancioglu,

LGTM, but would you mind quoting what error this fixes?

cevatbostancioglu commented 5 years ago

Hi @jforissier , Thanks for reply.

Platform: Docker container, inherited from Ubuntu 16.04 $ uname -a Linux CevatsContainer 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Error:

make[1]: Entering directory '/opt/optee/buildroot' mkdir -p /opt/optee/out-br/build/buildroot-config/lxdialog PKG_CONFIG_PATH="" make CC="/usr/bin/gcc" HOSTCC="/usr/bin/gcc" \ obj=/opt/optee/out-br/build/buildroot-config -C support/kconfig -f Makefile.br conf /usr/bin/gcc -D_GNU_SOURCE -DCURSESLOC="" -DLOCALE -I/opt/optee/out-br/build/buildroot-config -DCONFIG=\"\" -MM *.c > /opt/optee/out-br/build/buildroot-config/.depend 2>/dev/null || : /usr/bin/gcc -D_GNU_SOURCE -DCURSESLOC="" -DLOCALE -I/opt/optee/out-br/build/buildroot-config -DCONFIG=\"\" -c conf.c -o /opt/optee/out-br/build/buildroot-config/conf.o /usr/bin/gcc -D_GNU_SOURCE -DCURSESLOC="" -DLOCALE -I/opt/optee/out-br/build/buildroot-config -DCONFIG=\"\" -I. -c /opt/optee/out-br/build/buildroot-config/zconf.tab.c -o /opt/optee/out-br/build/buildroot-config/zconf.tab.o /usr/bin/gcc -D_GNU_SOURCE -DCURSESLOC="" -DLOCALE -I/opt/optee/out-br/build/buildroot-config -DCONFIG=\"\" /opt/optee/out-br/build/buildroot-config/conf.o /opt/optee/out-br/build/buildroot-config/zconf.tab.o -o /opt/optee/out-br/build/buildroot-config/conf rm /opt/optee/out-br/build/buildroot-config/zconf.tab.c GEN /opt/optee/out-br/Makefile #

configuration written to /opt/optee/out-br/.config

# make[1]: Leaving directory '/opt/optee/buildroot' make[1]: Entering directory '/opt/optee/out-br' /usr/bin/make -j1 O=/opt/optee/out-br HOSTCC="/usr/bin/gcc" HOSTCXX="/usr/bin/g++" syncconfig make[3]: warning: -jN forced in submake: disabling jobserver mode. GEN /opt/optee/out-br/Makefile You must install 'rsync' on your build machine support/dependencies/dependencies.mk:27: recipe for target 'dependencies' failed make[2]: [dependencies] Error 1 Makefile:23: recipe for target '_all' failed make[1]: [_all] Error 2 make[1]: Leaving directory '/opt/optee/out-br' common.mk:201: recipe for target 'buildroot' failed make: *** [buildroot] Error 2

jenswi-linaro commented 5 years ago

We're using rsync in Buildroot to copy the optee_*.gits into the build directory.

cevatbostancioglu commented 5 years ago
jforissier commented 5 years ago

@jenswi-linaro @cevatbostancioglu OK, I wasn't aware of that.

@cevatbostancioglu would you mind mentioning that buildroot requires rsync in your commit message?

Anyway: Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

cevatbostancioglu commented 5 years ago

@jforissier

jbech-linaro commented 5 years ago

I've totally missed that too. Thanks! Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

cevatbostancioglu commented 5 years ago

@jbech-linaro @jforissier it's been a 1 week, do i have to do something else about this pr to be merged?

jforissier commented 5 years ago

Please add your Signed-off-by: tag and @jbech-linaro's Reviewed-by: tag.

cevatbostancioglu commented 5 years ago

@jforissier thanks for the response.

jforissier commented 5 years ago

Thanks. No blank line between the S-o-b: and R-b: tags please ;-)

cevatbostancioglu commented 5 years ago

@jforissier updated.

jbech-linaro commented 5 years ago

Thanks @cevatbostancioglu !