core: ffa: Improve FF-A memory sharing compliance

OP-TEE / optee_os

Trusted side of the TEE

Other

1.56k stars 1.05k forks source link

core: ffa: Improve FF-A memory sharing compliance #6882

Closed imre-kis-arm closed 3 months ago

imre-kis-arm commented 3 months ago

Deny memory regions with zero pages
Validate total page count field
Validate total descriptor size including memory regions descriptors
Deny unsupported fragmented operations
Fix incorrect FFA_ERROR status codes
Return transaction type flag in retrieve response

Added test cases to SPMC test SPs to cover error handling branches in the memory sharing related functions: https://review.trustedfirmware.org/c/TS/trusted-services/+/28384

imre-kis-arm commented 3 months ago

Many changes in this commit, a bit hard to follow. Maybe split it in pieces? That is just a suggestion, not a very strong opinion.

I split this PR into three patches. The content is the same, except the fixed condition in thread_spmc.c.

imre-kis-arm commented 3 months ago

2 nitpicking comments, otherwise looks good to me. Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> for the series, with the my comments addressed or not.

Added Acked-by.

imre-kis-arm commented 3 months ago

I rebased the PR so it has the FORCE_UNSAFE_CONFIGURE fix but now it fails when it tries to download the Rust toolchain. Is this a known issue or is it just a temporary network error?

imre-kis-arm commented 3 months ago

Could you please merge this PR if there are no further concerns with it?

jforissier commented 3 months ago

@imre-kis-arm sure, sorry I missed it.

imre-kis-arm commented 3 months ago

Thank you.