search

OP-TEE / optee_os

Trusted side of the TEE
Other
1.51k stars 1.03k forks source link

fix use of calloc() against GCC 14.1 directive -Wcalloc-transposed-args #6912

Closed etienne-lms closed 1 day ago

etienne-lms commented 3 days ago

This change complements https://github.com/OP-TEE/optee_os/pull/6853. Changes in libtomcrypt are under review in https://github.com/libtom/libtomcrypt/pull/647. No functional changes.

GseoC commented 3 days ago

Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com>

GseoC commented 3 days ago

By the way, when issues are found in an external component, what are the steps to follow? Should we fix it in OP-TEE and in the component independently or should we wait for the merge in the component tree and backport it in OP-TEE?

etienne-lms commented 2 days ago

I think the issue should be fixed in both: in the original component and in OP-TEE. Fixing the original component does not means OP-TEE should upgrade to the latest (fixed) release of that component which may have other implication. Picking the fix can be enough.

For the very case of this change, as it is quite simple, https://github.com/libtom/libtomcrypt/pull/647 has been quite quickly merged. I think it ok we only pick the fix, as proposed in this P-R.

Maybe should I refer to https://github.com/libtom/libtomcrypt/pull/647 (or to https://github.com/libtom/libtomcrypt/commit/2302a3a89752b317d59e9cdb67d2d4eb9b53be8e) in the commit message.

For info: the checkpatch warning report is due to the build error trace message that exceeds 75 char/line in the commit message.

jenswi-linaro commented 2 days ago

Maybe should I refer to libtom/libtomcrypt#647 (or to libtom/libtomcrypt@2302a3a) in the commit message.

Yes, please.

jforissier commented 2 days ago

One minor thing: for the second commit, I'd rather use the libtomcrypt: prefix than core: ltc since it is really a libtomcrypt fix (as opposed to a fix in the integration code with the core). For both commits: Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

etienne-lms commented 1 day ago

I've updated the commit messages and applied posted review tags.

jenswi-linaro commented 1 day ago

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

jforissier commented 1 day ago

FYI I have cherry-picked the libtomcrypt patch on top of import/libtomcrypt-1.18.2-develop-20240412.