OPCFoundation / UA-.NETStandard-Samples

Other
245 stars 179 forks source link

Bugfix for Quickstart Server: Convert RootId to NodeId explicitly with namespace #583

Closed c0c0bird closed 5 months ago

c0c0bird commented 6 months ago

Proposed changes

The Quickstart Server's NodeHandle class parses a "RootId" from a component's NodeId. The QuickstartNodeManager then tries to use that string as a NodeId. This fails, because the string does not contains a namespace.

This bugfix adds a property "RootNodeId" to the NodeHandle class, which converts the "RootId" to a valid NodeId within the component's namespace. It can be used wherever the root NodeId is needed.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

mregen commented 5 months ago

Thanks for catching this issue, string nodeid handling had been made more strict to catch coding errors in applications.