romanett commented 5 months ago

Proposed changes

Implement the method RefokeCertificate from Spec: [7.9.6 RevokeCertificate (https://reference.opcfoundation.org/GDS/v105/docs/7.9.6)]

Related Issues

Fixes #2471

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] Enhancement (non-breaking change which adds functionality)
[ ] Test enhancement (non-breaking change to increase test coverage)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[x] I have read the CONTRIBUTING doc.
[x] I have signed the CLA.
[x] I ran tests locally with my changes, all passed.
[x] I fixed all failing tests in the CI pipelines.
[x] I fixed all introduced issues with CodeQL and LGTM.
[x] I have added tests that prove my fix is effective or that my feature works and increased code coverage.
[x] I have added necessary documentation (if appropriate).
[x] Any dependent changes have been merged and published in downstream modules.

Further comments

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 53.96%. Comparing base (8d2be39) to head (6aad7ef).

Files	Patch %	Lines
...pc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs	70.83%	3 Missing and 4 partials :warning:
...a.Gds.Client.Common/GlobalDiscoveryServerClient.cs	75.00%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2497 +/- ## ========================================== - Coverage 53.97% 53.96% -0.01% ========================================== Files 335 335 Lines 64558 64589 +31 Branches 13273 13281 +8 ========================================== + Hits 34842 34858 +16 - Misses 25955 25958 +3 - Partials 3761 3773 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

romanett commented 4 months ago

2338 will change the authorization, changes needed on the PR merged last.

OPCFoundation / UA-.NETStandard

GDS: add Method RevokeCertificate to Client and Server #2497