codecov[bot]
commented
5 months ago Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.
Comparison is base (
deb3391) 52.98% compared to head (8d1d49c) 42.71%. Report is 4 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| ....Ua.Server/Aggregates/StdDevAggregateCalculator.cs | 0.00% | 5 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #2505 +/- ## =========================================== - Coverage 52.98% 42.71% -10.28% =========================================== Files 319 319 Lines 62985 62987 +2 Branches 12927 12928 +1 =========================================== - Hits 33375 26905 -6470 - Misses 25920 32781 +6861 + Partials 3690 3301 -389 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed changes
There are two obvious errors in the calculation of the StandardDeviationSample and VariancePopulation aggregates which are fixed with this PR. The linked issue #2360 also claims that there is a further issue with the way the bounds are included. This needs further investigation. As this may need more time, I preferred to fix the obvious errors immediately.
Related Issues
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...