OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.9k stars 926 forks source link

Avoid overwrite of endpoint description with invalid endpoint description on client session. #2506

Closed mrsuciu closed 5 months ago

mrsuciu commented 5 months ago

Proposed changes

Avoid overwrite of endpoint description with endpoint description of other endpoint than the one used in current session, in case server exposes multiple endpoints on different ports.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 5 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (deb3391) 52.98% compared to head (c97fcc0) 53.82%. Report is 4 commits behind head on master.

Files Patch % Lines
Libraries/Opc.Ua.Client/Session.cs 69.23% 4 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2506 +/- ## ========================================== + Coverage 52.98% 53.82% +0.83% ========================================== Files 319 334 +15 Lines 62985 64435 +1450 Branches 12927 13227 +300 ========================================== + Hits 33375 34679 +1304 - Misses 25920 25996 +76 - Partials 3690 3760 +70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.