Closed KircMax closed 4 months ago
I also added passing the cancellationtoken to the factory method but I can also undo it if you want - just noticed that the cancellationtoken exists and is not passed.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2b9d8f9
) 53.81% compared to head (85aac28
) 46.52%. Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mrsuciu had been looking into policyId issues recently, please code review as well.
Proposed changes
Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Related Issues
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...