OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.9k stars 926 forks source link

reuse the identity policy in the reconnect that has been used in the connect #2526

Closed KircMax closed 4 months ago

KircMax commented 4 months ago

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

KircMax commented 4 months ago

I also added passing the cancellationtoken to the factory method but I can also undo it if you want - just noticed that the cancellationtoken exists and is not passed.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2b9d8f9) 53.81% compared to head (85aac28) 46.52%. Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2526 +/- ## ========================================== - Coverage 53.81% 46.52% -7.30% ========================================== Files 334 284 -50 Lines 64409 58025 -6384 Branches 13235 11852 -1383 ========================================== - Hits 34663 26994 -7669 - Misses 25990 27829 +1839 + Partials 3756 3202 -554 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mregen commented 4 months ago

@mrsuciu had been looking into policyId issues recently, please code review as well.