OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.9k stars 926 forks source link

Remove lock from IServiceMessageContext #2532

Closed mregen closed 4 months ago

mregen commented 4 months ago

Proposed changes

Reduce lock contention for encoders/decoders.

The IServiceMessageContext locks all properties without really a need, because assigning/reading int and objects are transaction safe.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (61edad9) 53.96% compared to head (2677102) 53.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2532 +/- ## ========================================== - Coverage 53.96% 53.84% -0.12% ========================================== Files 334 334 Lines 64424 64416 -8 Branches 13239 13239 ========================================== - Hits 34764 34683 -81 - Misses 25907 25974 +67 - Partials 3753 3759 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.