OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.9k stars 926 forks source link

1.05.04 json encoder fixes v2 #2539

Open opcfoundation-org opened 4 months ago

opcfoundation-org commented 4 months ago

Proposed changes

Fixes to the JSON encoder to support the RC + NodeId/ExpandedNodeId/QualifiedName encoding,

CLAassistant commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: randy-armstrong
:white_check_mark: mrsuciu
:x: Randy Armstrong


Randy Armstrong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 1.67064% with 412 lines in your changes missing coverage. Please review.

Project coverage is 44.85%. Comparing base (f2815bb) to head (a1474a9).

Files Patch % Lines
...s/Opc.Ua.Server/Configuration/ConfigurationFile.cs 0.00% 119 Missing :warning:
Stack/Opc.Ua.Core/Types/BuiltIn/NodeId.cs 3.84% 73 Missing and 2 partials :warning:
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs 0.00% 72 Missing :warning:
Stack/Opc.Ua.Core/Types/BuiltIn/ExpandedNodeId.cs 1.56% 63 Missing :warning:
Stack/Opc.Ua.Core/Types/BuiltIn/QualifiedName.cs 0.00% 36 Missing :warning:
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 0.00% 23 Missing :warning:
Stack/Opc.Ua.Core/Types/Utils/Utils.cs 25.00% 7 Missing and 2 partials :warning:
Stack/Opc.Ua.Core/Schema/UANodeSet.cs 0.00% 6 Missing :warning:
Stack/Opc.Ua.Core/Schema/UANodeSetHelpers.cs 0.00% 4 Missing :warning:
...Ua.Core/Types/BuiltIn/SessionLessServiceMessage.cs 0.00% 2 Missing :warning:
... and 3 more

:exclamation: There is a different number of reports uploaded between BASE (f2815bb) and HEAD (a1474a9). Click for more details.

HEAD has 20 uploads less than BASE | Flag | BASE (f2815bb) | HEAD (a1474a9) | |------|------|------| ||50|30|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2539 +/- ## ========================================== - Coverage 54.72% 44.85% -9.87% ========================================== Files 347 301 -46 Lines 65535 60560 -4975 Branches 13433 12322 -1111 ========================================== - Hits 35866 27167 -8699 - Misses 25768 30372 +4604 + Partials 3901 3021 -880 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.