Added a limit to the Channels on the server side and removed "stale" channels

mrsuciu commented 4 months ago

Proposed changes

Added a limit to the number of Channels on the server side and removed "stale" channels. Add option to console client to leak channels and run forever.

Related Issues

Fixes #

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

[x] Bugfix (non-breaking change which fixes an issue)
[ ] Enhancement (non-breaking change which adds functionality)
[ ] Test enhancement (non-breaking change to increase test coverage)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
[ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc.
[x] I have signed the CLA.
[ ] I ran tests locally with my changes, all passed.
[ ] I fixed all failing tests in the CI pipelines.
[ ] I fixed all introduced issues with CodeQL and LGTM.
[ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage.
[ ] I have added necessary documentation (if appropriate).
[ ] Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 73.61111% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 54.58%. Comparing base (884ddf3) to head (8a2e9d6).

Files	Patch %	Lines
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs	68.29%	9 Missing and 4 partials :warning:
Stack/Opc.Ua.Core/Stack/Tcp/TcpListenerChannel.cs	42.10%	7 Missing and 4 partials :warning:
Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.cs	50.00%	5 Missing and 1 partial :warning:
...k/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs	28.57%	2 Missing and 3 partials :warning:
Libraries/Opc.Ua.Server/Server/StandardServer.cs	71.42%	0 Missing and 2 partials :warning:
...c.Ua.Core/Stack/Tcp/UaSCBinaryChannel.Symmetric.cs	0.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2540 +/- ## ========================================== - Coverage 54.70% 54.58% -0.13% ========================================== Files 342 342 Lines 65041 65082 +41 Branches 13331 13350 +19 ========================================== - Hits 35581 35522 -59 - Misses 25612 25682 +70 - Partials 3848 3878 +30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mregen commented 4 months ago

some tests are failing, is all yet updated for the new state?

EthanChangAED commented 3 months ago

@mregen, please review the updates.

mregen commented 3 months ago

@mregen, please review the updates.

testing this next...

mregen commented 2 months ago

tested and looks all good to me.. :shipit:

OPCFoundation / UA-.NETStandard