OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.9k stars 926 forks source link

*DRAFT* Add EventMonitoredItem comfort #2543

Open KircMax opened 4 months ago

KircMax commented 4 months ago

Proposed changes

This is not a proposal yet. I just want to create a discussion basis in order to from that create a Pull Request that contains these changes in a way it will be okay to include this into the repository. I just copied some Extensions I have currently build up on top of the MonitoredItem that make Event Handling easier for me.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

I just want to kick off the discussion for how this could be done. This is absolutely not final.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 4.66667% with 143 lines in your changes are missing coverage. Please review.

Project coverage is 54.35%. Comparing base (3f29a72) to head (9616b83).

Files Patch % Lines
Libraries/Opc.Ua.Client/MonitoredItem.cs 14.28% 40 Missing and 2 partials :warning:
Libraries/Opc.Ua.Client/Methods/MethodBase.cs 0.00% 38 Missing :warning:
Libraries/Opc.Ua.Client/Events/Extensions.cs 0.00% 27 Missing :warning:
Libraries/Opc.Ua.Client/Events/OpcEvent.cs 0.00% 12 Missing :warning:
....Client/Events/OpcUaEventFieldNotFoundException.cs 0.00% 10 Missing :warning:
...ies/Opc.Ua.Client/Methods/EventMethodCollection.cs 0.00% 4 Missing :warning:
...ies/Opc.Ua.Client/Methods/MethodCallReturnValue.cs 0.00% 4 Missing :warning:
Libraries/Opc.Ua.Client/Methods/EventMethod.cs 0.00% 3 Missing :warning:
Libraries/Opc.Ua.Client/Events/EventField.cs 0.00% 2 Missing :warning:
Libraries/Opc.Ua.Client/Methods/OutputArgument.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2543 +/- ## ========================================== - Coverage 54.45% 54.35% -0.10% ========================================== Files 335 344 +9 Lines 64749 64899 +150 Branches 13292 13312 +20 ========================================== + Hits 35256 35273 +17 - Misses 25657 25785 +128 - Partials 3836 3841 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.