OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.89k stars 926 forks source link

[Server] Fix Shutdown Delay when registration is enabled no LDS is present. #2589

Closed romanett closed 2 months ago

romanett commented 2 months ago

Proposed changes

The server no remembers if a registration with a LDS was done and only tries to unregister on shutdown if this is the case. This mitigates the shutdown delay when no LDS is present on the network.

Benchmark:

Test Runtime for Server Shutdown Test decreased from >10s to <2s

Related Issues

Types of changes

Checklist

Further comments

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 54.64%. Comparing base (884ddf3) to head (11246a8). Report is 8 commits behind head on master.

Files Patch % Lines
Libraries/Opc.Ua.Server/Server/StandardServer.cs 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2589 +/- ## ========================================== - Coverage 54.70% 54.64% -0.07% ========================================== Files 342 342 Lines 65041 65059 +18 Branches 13331 13335 +4 ========================================== - Hits 35581 35549 -32 - Misses 25612 25637 +25 - Partials 3848 3873 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.