Closed mrsuciu closed 2 months ago
Attention: Patch coverage is 76.31579%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 54.53%. Comparing base (
2aec785
) to head (c967726
). Report is 27 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I suggest to use #2720 instead, less complicated...
Proposed changes
The Rejected store currently keeps all the rejected certificates. This PR proposes that the Rejected store should keep only a limited value of the 5 last rejected certificates. It also eliminates the redundant check for existing certificates in the X509CertificateStore and DirectoryCertificateStore.
Related Issues
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...