OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

(bug) fix #2697 - m_keepAliveInterval should always be >= kMinKeepAliveTimerInterval #2698

Closed BoBiene closed 3 months ago

BoBiene commented 3 months ago

Proposed changes

m_keepAliveInterval should never get below kMinKeepAliveTimerInterval

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.73%. Comparing base (784dde6) to head (64d9153).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2698 +/- ## ========================================== - Coverage 54.54% 53.73% -0.81% ========================================== Files 347 347 Lines 65592 65592 Branches 13445 13445 ========================================== - Hits 35774 35244 -530 - Misses 25892 26458 +566 + Partials 3926 3890 -36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BoBiene commented 3 months ago

@mregen is it possible to get a preview build of the nugets including this fix?

mregen commented 3 months ago

@BoBiene please check the preview feed as configured here: opcua-preview. Version 1.5.374.xx-preview