OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Moved the modified reference server from the unit test to its own file #2725

Closed ThomasNehring closed 1 month ago

ThomasNehring commented 3 months ago

Also moved the modified (server side) session, the modified session manager and the modified master node manager to the same file.

Proposed changes

The unit test ContinuationPointInBatchTest was developed together with a modified reference server which allows to change the limit for (browse) ContinuationPoints during the test. To allow easier reuse of this modified reference server and to make the unit test better readable, the modified reference server is now moved into it's own file.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.73%. Comparing base (c16d1f2) to head (50b852a). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2725 +/- ## ========================================== - Coverage 54.73% 54.73% -0.01% ========================================== Files 349 349 Lines 65975 65975 Branches 13534 13534 ========================================== - Hits 36114 36113 -1 - Misses 25939 25943 +4 + Partials 3922 3919 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mregen commented 2 months ago

@ThomasNehring please merge with master to ensure latest changes were captured

ThomasNehring commented 1 month ago

@mregen I just merged master successfully into this branch.