OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Allow bad status code for optional Attributes in ReadNodes #2730

Closed NoahHoelterhoff closed 3 months ago

NoahHoelterhoff commented 3 months ago

Proposed changes

ReadNodes() (and some other methods) allow bad status codes for optional values. However, this list is not complete, which means that some optional attributes with a Bad StatusCode cause the read to fail. This Pull Request does not fix something, which is wrong (according to the specification), but rather increases the resilience against servers with problems.

List of optional attributes: https://reference.opcfoundation.org/Core/Part3/v105/docs/5.9

Related Issues

Types of changes

What types of changes does your code introduce?

Checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.64%. Comparing base (9b0e480) to head (ed473db). Report is 3 commits behind head on master.

Files Patch % Lines
Libraries/Opc.Ua.Client/Session/Session.cs 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2730 +/- ## ========================================== - Coverage 55.01% 54.64% -0.38% ========================================== Files 349 349 Lines 65872 65903 +31 Branches 13492 13494 +2 ========================================== - Hits 36242 36010 -232 - Misses 25777 25997 +220 - Partials 3853 3896 +43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.