OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Skip client server cert app uri validation due to IOP issues #2733

Closed mregen closed 3 months ago

mregen commented 3 months ago

Proposed changes

Skip the client validation of the application Uri in the server certificate agoinst the returned endpoint in the create session response. Due to IOP issues with old servers in production there needs to be a solution which allows to suppress the check.

Working on a better integration of the check (#2731)

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.65%. Comparing base (54b287c) to head (9739c03).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2733 +/- ## ========================================== + Coverage 54.64% 54.65% +0.01% ========================================== Files 349 349 Lines 65879 65877 -2 Branches 13492 13492 ========================================== + Hits 36000 36007 +7 + Misses 25978 25972 -6 + Partials 3901 3898 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

romanett commented 3 months ago

@mregen can you reopen the original issue bringing this up until we have a fix