OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

August release testing: Improve cert blob decoding hot path and fix cert validator semaphore regression #2748

Closed mregen closed 2 months ago

mregen commented 2 months ago

Proposed changes

Testing the release bits, the following issues were discovered:

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.

Project coverage is 54.68%. Comparing base (4bbb062) to head (be681c5). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...Core/Security/Certificates/CertificateValidator.cs 60.00% 6 Missing and 2 partials :warning:
...ies/Opc.Ua.Server/Server/OpcUaServerEventSource.cs 28.57% 3 Missing and 2 partials :warning:
...a.Core/Security/Certificates/CertificateFactory.cs 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2748 +/- ## ========================================== - Coverage 54.71% 54.68% -0.03% ========================================== Files 349 349 Lines 65683 65689 +6 Branches 13438 13439 +1 ========================================== - Hits 35938 35923 -15 - Misses 25853 25869 +16 - Partials 3892 3897 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mregen commented 2 months ago

updated with semaphore check (most importantly as it can cause a deadlock)