OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Release testing: Fix channel remove issue and channel exhaustion on reconnect #2749

Closed mregen closed 2 months ago

mregen commented 2 months ago

Proposed changes

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.63%. Comparing base (6833b91) to head (a160549).

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Stack/Tcp/TcpListenerChannel.cs 8.33% 7 Missing and 4 partials :warning:
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 84.61% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2749 +/- ## ========================================== - Coverage 54.64% 54.63% -0.02% ========================================== Files 349 349 Lines 65689 65694 +5 Branches 13439 13440 +1 ========================================== - Hits 35899 35891 -8 - Misses 25893 25910 +17 + Partials 3897 3893 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.