OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Remove https package from OPCFoundation.NetStandard.Opc.Ua dependencies, causes build issues. #2751

Closed mregen closed 2 months ago

mregen commented 2 months ago

Proposed changes

Multiple isses were reported when the OPCFoundation.NetStandard.Opc.Ua package is used with netstandard2.0 or unity, likely caused by dependencies in the https kestrel package. Make the https package optional (user needs to add it to the list of dependencies).

Package is also marked deprecated on Nuget.org.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.74%. Comparing base (6833b91) to head (48de911).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2751 +/- ## ========================================== + Coverage 54.64% 54.74% +0.09% ========================================== Files 349 349 Lines 65689 65689 Branches 13439 13439 ========================================== + Hits 35899 35963 +64 + Misses 25893 25834 -59 + Partials 3897 3892 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.