OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Openstore returns null if CertificateIdentifier is empty #2761

Closed mregen closed 2 months ago

mregen commented 2 months ago

Proposed changes

August testing:

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.05%. Comparing base (41363bd) to head (c767d35). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ndings.Https/Stack/Https/HttpsTransportListener.cs 57.14% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2761 +/- ## ========================================== - Coverage 55.16% 55.05% -0.12% ========================================== Files 349 349 Lines 65694 65697 +3 Branches 13440 13441 +1 ========================================== - Hits 36239 36167 -72 - Misses 25618 25692 +74 - Partials 3837 3838 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.