Closed mregen closed 1 month ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.
:white_check_mark: randy-armstrong
:white_check_mark: mregen
:white_check_mark: mrsuciu
:x: Randy Armstrong
Attention: Patch coverage is 66.81319%
with 151 lines
in your changes missing coverage. Please review.
Project coverage is 54.76%. Comparing base (
cf2e788
) to head (9b0e747
). Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mrsuciu @NoahHoelterhoff I checked your concern but I think the implementation is ok as is.
Proposed changes
Add support for new Compact and Verbose JSON encodings.
Other bug fixes:
Related Issues
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...