OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Pubsub JSON updates preview #2768

Closed mregen closed 1 month ago

mregen commented 2 months ago

Proposed changes

Add support for new Compact and Verbose JSON encodings.

Other bug fixes:

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: randy-armstrong
:white_check_mark: mregen
:white_check_mark: mrsuciu
:x: Randy Armstrong


Randy Armstrong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.81319% with 151 lines in your changes missing coverage. Please review.

Project coverage is 54.76%. Comparing base (cf2e788) to head (9b0e747). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs 66.92% 20 Missing and 22 partials :warning:
Stack/Opc.Ua.Core/Types/BuiltIn/NodeId.cs 55.00% 24 Missing and 12 partials :warning:
Stack/Opc.Ua.Core/Types/BuiltIn/ExpandedNodeId.cs 58.10% 22 Missing and 9 partials :warning:
Stack/Opc.Ua.Core/Types/BuiltIn/QualifiedName.cs 47.22% 11 Missing and 8 partials :warning:
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 87.28% 14 Missing and 1 partial :warning:
Stack/Opc.Ua.Core/Types/Utils/Utils.cs 57.89% 5 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2768 +/- ## ========================================== - Coverage 55.04% 54.76% -0.28% ========================================== Files 349 349 Lines 65697 66018 +321 Branches 13441 13542 +101 ========================================== - Hits 36162 36157 -5 - Misses 25688 25937 +249 - Partials 3847 3924 +77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mregen commented 1 month ago

@mrsuciu @NoahHoelterhoff I checked your concern but I think the implementation is ok as is.