OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Do not create the default folders for DirectoryStore on Open #2773

Closed mregen closed 1 month ago

mregen commented 1 month ago

Proposed changes

For convenience, the DirectoryStore class creates the default folders when the DirectoryStore is opened. (since #2720) However this may lead into issues mapping folders to the store when started in docker.

Fix: remove the code which creates default folders and ensure a null directory does not throw a NullReferenceException.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.72%. Comparing base (5349d9a) to head (8da3156). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...Security/Certificates/DirectoryCertificateStore.cs 33.33% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2773 +/- ## ========================================== + Coverage 54.62% 54.72% +0.09% ========================================== Files 349 349 Lines 65705 65691 -14 Branches 13446 13442 -4 ========================================== + Hits 35889 35947 +58 + Misses 25923 25861 -62 + Partials 3893 3883 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mregen commented 1 month ago

@ThomasNehring I removed the other create and added some more sanity check for null, just to be safe