OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

#2777 Fix for - MonitoredItem2.OnReportEvent Ignores Session in ISystemContext During Notification Process #2779

Closed Filippo-Oliva-ABB closed 1 month ago

Filippo-Oliva-ABB commented 1 month ago

Proposed changes

Check the Session included in the ISystemContext instance, if any, and compare it with those belonging to the monitored items. If the ISystemContext instance contains a Session, the event will be appended only to the monitored items belonging to the same Session. If the ISystemContext instance does not contain a Session, the event will be appended to all monitored items, regardless of their sessions.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.89%. Comparing base (36dbdd3) to head (de90da9). Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...braries/Opc.Ua.Server/Diagnostics/MonitoredNode.cs 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2779 +/- ## ========================================== + Coverage 54.62% 54.89% +0.26% ========================================== Files 349 349 Lines 65697 66075 +378 Branches 13441 13560 +119 ========================================== + Hits 35886 36269 +383 + Misses 25917 25881 -36 - Partials 3894 3925 +31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mregen commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).