codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 54.93%. Comparing base (
9c7b321) to head (492f2b2).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...braries/Opc.Ua.Server/Diagnostics/MonitoredNode.cs | 50.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #2792 +/- ## ========================================== - Coverage 55.40% 54.93% -0.48% ========================================== Files 349 349 Lines 66055 66049 -6 Branches 13549 13547 -2 ========================================== - Hits 36597 36282 -315 - Misses 25572 25837 +265 - Partials 3886 3930 +44 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed changes
…hen a change is notified (#2772)" This reverts commit 9c7b321ecb609537c95391f6deddf1ad9d1317c2.
During tests the new code ran into an ArgumentNullException creating a new OperationContext. Even with more checks I have performance concerns about the copy of the servicecontext and the new OperationContext for every data change, it may affect the server perf. We need to find a better solution.
Related Issues
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...